-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use of environment variables for controlling the active mutation #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dupdob
force-pushed
the
restore_env_variable_controls
branch
4 times, most recently
from
November 25, 2024 10:53
348ad46
to
9b885e9
Compare
dupdob
force-pushed
the
restore_env_variable_controls
branch
from
November 25, 2024 12:26
9b885e9
to
6ec42a3
Compare
richardwerkman
previously requested changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, some small remarks
src/Stryker.Core/Stryker.Core/TestRunners/VsTest/VsTestContextInformation.cs
Outdated
Show resolved
Hide resolved
src/Stryker.Core/Stryker.Core/TestRunners/VsTest/VsTestContextInformation.cs
Show resolved
Hide resolved
integrationtest/TargetProjects/NetCore/Library.FSharp.XUnit/Library.FSharp.XUnit.fsproj
Outdated
Show resolved
Hide resolved
src/Stryker.Core/Stryker.Core/TestRunners/VsTest/VsTestRunner.cs
Outdated
Show resolved
Hide resolved
…ryker-mutator/stryker-net into restore_env_variable_controls
src/Stryker.Core/Stryker.Core/TestRunners/VsTest/VsTestContextInformation.cs
Outdated
Show resolved
Hide resolved
rouke-broersma
changed the title
Restore the use of environment variables for controlling the active mutation
feat: Restore the use of environment variables for controlling the active mutation
Dec 20, 2024
rouke-broersma
changed the title
feat: Restore the use of environment variables for controlling the active mutation
feat: Use of environment variables for controlling the active mutation
Dec 20, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore and improve the use of an environment variable to control the active mutation.
Now each runner gets a specific environment variables to prevent race condition when executing the test.
The variable is used when there is a single active mutation for the test session.
Also, disable coverage analysis based optimizations when coverage capture seems to have failed (no coverage reported).
This changes will allow support for xUnitV3 tests, albeit slow.
Note: I had to upgrade the F# integration test project to Net 8.0 because Net 6.0 was not available on the CI runner and this broke the build. I see no reason why this could be related to the changes I made, so I assume this is due to Net 6.0 being phased out by MS.